[CI:DOCS] Pin actions to a full length commit SHA #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Pin actions to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. Ref: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions + Explicitly set permissions for actions to minimum required. The defaults are (unfortunately) overly permissive: Ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token Signed-off-by: Chris Evich <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to similar changes made in Buildah, Podman, and Skopeo: containers/podman#13564 containers/buildah#3872 containers/skopeo#1652
Pin actions to a full length commit SHA is currently the only way
to use an action as an immutable release. Pinning to a particular SHA
helps mitigate the risk of a bad actor adding a backdoor to the action's
repository, as they would need to generate a SHA-1 collision for a valid
Git object payload. Ref:
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
Explicitly set permissions for actions to minimum required. The
defaults are (unfortunately) overly permissive: Ref:
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
Signed-off-by: Chris Evich [email protected]