Deprecate MachineEnabled and replace with API #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhatdan @TomSweeneyRedHat @Luap99 PTAL when you have a chance, updates per discussion in containers/podman#13908 |
|
Can you remove |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sure |
7f4b037
to
c2d8d2f
Compare
|
LGTM |
1 similar comment
|
LGTM |
Luap99
reviewed
Apr 23, 2022
machine.IsPodmanMachine replaces MachineEnabled machine.MachineHostType informs the type unknown, qemu, wsl, etc machine.IsGvProxyBased used to make specific determinations re gvproxy Signed-off-by: Jason T. Greene <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates config.Engine.MachineEnabled, and replaces it with a file marker based API:
machine.IsPodmanMachine replaces MachineEnabled
machine.MachineHostType informs the type unknown, qemu, wsl, etc
machine.IsGvProxyBased used to make specific determinations re gvproxy
This is only a soft deprecation, I assume we want to avoid throwing up lint errors just yet.
Signed-off-by: Jason T. Greene [email protected]