Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance tests: use mirror.gcr.io for most images #5673

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

nalind
Copy link
Member

@nalind nalind commented Aug 7, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Use busybox and alpine images from mirror.gcr.io, where possible, to avoid tripping pull limits in CI.

How to verify it

So many updated conformance tests!

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2024
@TomSweeneyRedHat
Copy link
Member

LGTM
@edsantiago if you can give this a quick looksee, I'd appreciate it.

@edsantiago
Copy link
Member

I'm confused. There's already a registries.conf that fixes this. Is it not fixing it? What problem are we seeing?

@edsantiago
Copy link
Member

hold on, I merged local-registry in #5584. We should absolutely not be using any network pulls any more! What's happening?

@nalind
Copy link
Member Author

nalind commented Aug 8, 2024

Conformance tests use docker build with the docker daemon and friends as the baseline, and they don't pay attention to registries.conf. In order to use the same base images, the code paths that use buildah can't either.

@nalind
Copy link
Member Author

nalind commented Aug 8, 2024

Well, not docker build per se, but the REST API that the docker engine provides.

Use busybox and alpine images from mirror.gcr.io, where possible, to
avoid tripping pull limits in CI.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Aug 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8f86260 into containers:main Aug 9, 2024
37 checks passed
@nalind nalind deleted the conformance-mirror branch August 9, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants