Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v1.19.1 #2912

Closed

Conversation

TomSweeneyRedHat
Copy link
Member

As the title says.

Bumping to v1.19.1

Signed-off-by: TomSweeneyRedHat <[email protected]>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member Author

@nalind @rhatdan PTAL

@@ -100,6 +100,9 @@ make DESTDIR=%{buildroot} PREFIX=%{_prefix} install install.completions
%{_datadir}/bash-completion/completions/*

%changelog
* Fri Jan 8, 2021 Tom Sweeney <[email protected]> 1.19.1-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date looks off, but not a blocker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Thanks, fixed and repushed.

Signed-off-by: TomSweeneyRedHat <[email protected]>
@nalind
Copy link
Member

nalind commented Jan 14, 2021

LGTM, but it's either this one and moving the v1.19.1 tag, or #2911.

@TomSweeneyRedHat
Copy link
Member Author

TomSweeneyRedHat commented Jan 14, 2021

I think it needs to be this one as #2911 has a different version of c/common than what is in Podman 3.0 and they need to sync.

@rhatdan
Copy link
Member

rhatdan commented Jan 15, 2021

Already forced this through, but we need another fix.

@rhatdan rhatdan closed this Jan 15, 2021
@nalind
Copy link
Member

nalind commented Jan 15, 2021

Already forced this through, but we need another fix.

Can you elaborate? I'm looking at this and I have no idea what's going on.

@rhatdan
Copy link
Member

rhatdan commented Jan 15, 2021

Were all set, I opened PRs to fix an issue with pkg/overlay.
Buildah 1.19.2 is the current release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants