Add support for /run/.containerenv #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #1843 |
run_linux.go
Outdated
| // Empty file, so no need to recreate if it exists | ||
| if _, ok := bindFiles["/run/.containerenv"]; !ok { | ||
| // Empty string for now, but we may consider populating this later | ||
| containerenvPath := filepath.Join(path, "/run.containerenv") |
There was a problem hiding this comment.
should this be /run/.containerenv? (added a slash after run)
There was a problem hiding this comment.
I love typos... I guess tests would have found this. Fixed.
vrothberg
reviewed
Sep 6, 2019
rhatdan
force-pushed
the
containerenv
branch
from
7ce46b7
to
bc99264
Compare
|
LGTM |
|
@rh-atomic-bot r=TomSweeneyRedHat |
|
📌 Commit bc99264 has been approved by |
rhatdan
force-pushed
the
containerenv
branch
from
bc99264
to
83a8e9b
Compare
Container processes want to check for the existence of this file to determine if they are running inside of a container. Signed-off-by: Daniel J Walsh <[email protected]>
rhatdan
force-pushed
the
containerenv
branch
from
83a8e9b
to
7f0b60c
Compare
|
📌 Commit 7f0b60c has been approved by |
|
Hopefully the tests pass this time. Found a couple of other issues with this in the mean time. Was breaking ubuntu images and did not do SELinux correctly. Should be fixed now. |
|
bot, retest this please |
|
Homu is not responding. Manually merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container processes want to check for the existence of this file
to determine if they are running inside of a container.
Signed-off-by: Daniel J Walsh [email protected]