Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: use go proxy #1828

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Makefile: use go proxy #1828

merged 1 commit into from
Aug 30, 2019

Conversation

vrothberg
Copy link
Member

Use GOPROXY=https://proxy.golang.org to speed up fetching dependencies.
Setting it makes make vendor ten times faster in my local env.

For details please refer to https://proxy.golang.org/.

Signed-off-by: Valentin Rothberg [email protected]

@rhatdan
Copy link
Member

rhatdan commented Aug 30, 2019

LGTM
bot, retest this please

@vrothberg
Copy link
Member Author

bot, retest this please

Use GOPROXY=https://proxy.golang.org to speed up fetching dependencies.
Setting it makes `make vendor` ten times faster in my local env.

For details please refer to https://proxy.golang.org/.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

Repushed to restart the RH CI

@vrothberg
Copy link
Member Author

RH CI is sick (internal error). I vote for force-merging since this change has no functional impact.

@rhatdan rhatdan merged commit e930951 into containers:master Aug 30, 2019
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late, but LGTM

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants