Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host-local support idempotent allocation #328

Merged
merged 4 commits into from
Jul 24, 2019
Merged

host-local support idempotent allocation #328

merged 4 commits into from
Jul 24, 2019

Conversation

mars1024
Copy link
Member

@mars1024 mars1024 commented Jun 1, 2019

try to fix #327

@mars1024 mars1024 changed the title host-local should support idempotent allocation host-local support idempotent allocation Jun 1, 2019
@mars1024 mars1024 force-pushed the feature/hostlocal_idempotent branch from 4a10a21 to 83fba08 Compare June 1, 2019 10:58
jellonek
jellonek approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcbw
Copy link
Member

dcbw commented Jul 3, 2019 •
edited
Loading

@mars1024 Discussed this and we agree that this fixes a bug in host-local and is better than the current behavior. Could you update the plugin to instead return an error when an allocation exists for a given ID, since the spec mandates that plugins "must" not call ADD for the same tuple?

@mars1024
Copy link
Member Author

mars1024 commented Jul 4, 2019

@mars1024 Discussed this and we agree that this fixes a bug in host-local and is better than the current behavior. Could you update the plugin to instead return an error when an allocation exists for a given ID, since the spec mandates that plugins "must" not call ADD for the same tuple?

OK, I'll update this soon. :)

@mars1024 mars1024 force-pushed the feature/hostlocal_idempotent branch from 83fba08 to e2984e7 Compare July 6, 2019 02:10
@mars1024
Copy link
Member Author

mars1024 commented Jul 6, 2019 •
edited
Loading

Updated! cc @dcbw
Now host-local will support idempotent allocation in this way, if a given ID has an allocated IP, the follow-up requests with this ID will be rejected until it release the allocated IP.

@mars1024
Copy link
Member Author

@dcbw @squeed @bboreham @rosenhouse If you have time, please take a look at this updated PR this week, thanks a lot ~

@rosenhouse rosenhouse mentioned this pull request Jul 17, 2019
Closed
@squeed
Copy link
Member

squeed commented Jul 17, 2019

lgtm, thanks!

@mars1024
Copy link
Member Author

@dcbw @bboreham Could you help to promote the updated PR this week?

@dcbw
Copy link
Member

dcbw commented Jul 24, 2019

LGTM

@squeed squeed merged commit ded2f17 into containernetworking:master Jul 24, 2019
@squeed
Copy link
Member

squeed commented Jul 24, 2019

Done! We expect to be tagging another release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellonek jellonek jellonek approved these changes

@matthewdupre matthewdupre matthewdupre approved these changes

@dcbw dcbw dcbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

host-local should support idempotent allocation
5 participants
@mars1024 @dcbw @squeed @jellonek @matthewdupre