Add static CNI plugin #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes to add 'static' CNI plugin, which provides to assign IPv4/v6 address statically from given config file. See README.md for the details.
bboreham
approved these changes
Apr 4, 2018
|
Might there be any reason for this to have locking? In other words, only allow the IP to be issued to one running container. I suppose if you're using this plugin, you are in debug mode. But it may be a good idea to add. |
|
@squeed I'd say locking could be added later, perhaps? Also, because it's static, even locking wouldn't prevent assigning the same IP to two containers on different nodes. The locking would only help for containers on the same node. |
|
@squeed said in the maintainers meeting he had no problem with the locking issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes to add 'static' CNI plugin, which provides to assign IPv4/v6 address statically from given config file. See README.md for the details.