Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project repo checks #21

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

estesp
Copy link
Member

@estesp estesp commented Nov 7, 2018

Add headers with ltag; add checks to travis; and common project references to README.

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   57.71%   57.71%           
=======================================
  Files           1        1           
  Lines         175      175           
=======================================
  Hits          101      101           
  Misses         49       49           
  Partials       25       25
Impacted Files Coverage Δ
zfs.go 57.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6ef3b...2f23511. Read the comment docs.

README.md Outdated

## Project details

zfs is a containerd sub-project, licensed under the [Apache 2.0 license](./LICENSE).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "zfs" -> "zfs plugin"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 31af176 into containerd:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants