Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update containerd #19

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Conversation

AkihiroSuda
Copy link
Member

Signed-off-by: Akihiro Suda [email protected]

Signed-off-by: Akihiro Suda <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   57.71%   57.71%           
=======================================
  Files           1        1           
  Lines         175      175           
=======================================
  Hits          101      101           
  Misses         49       49           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a0b8b8...154f951. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; maybe in a follow-up PR there should be either 1) pin containerd to a release version in .travis.yml or 2) remove comment about no pinning until 1.0.0 GA; also Go version could be updated to match containerd

@AkihiroSuda
Copy link
Member Author

I think there was a discussion on moving all plugins into the monorepo, so as to avoid circular vendoring.

CRI plugin would need more discussion, but w.r.t. ZFS and AUFS, I guess we can move them to the monorepo?

@dmcgowan
Copy link
Member

LGTM

@dmcgowan dmcgowan merged commit 39692b4 into containerd:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants