Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ctr pull metadata-only #9791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ningmingxiao
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link

Hi @ningmingxiao. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ningmingxiao
Copy link
Contributor Author

@mxpv
Copy link
Member

mxpv commented Feb 8, 2024

Trying to understand this if statement:

if context.Bool("metadata-only") {
  sopts = append(sopts, image.WithAllMetadata)
} else if !context.Bool("skip-metadata") {
  sopts = append(sopts, image.WithAllMetadata)
}

we don't need both flags, right?
we include all metadata by default unless skip-metadata specified.

@ningmingxiao
Copy link
Contributor Author

Trying to understand this if statement:

if context.Bool("metadata-only") {
  sopts = append(sopts, image.WithAllMetadata)
} else if !context.Bool("skip-metadata") {
  sopts = append(sopts, image.WithAllMetadata)
}

we don't need both flags, right? we include all metadata by default unless skip-metadata specified.

done

@ningmingxiao
Copy link
Contributor Author

already rebase

Signed-off-by: ningmingxiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants