Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.3 backport] Update to Golang 1.12.13 #3808

Merged

Conversation

thaJeztah
Copy link
Member

backport of #3806 for the 1.3 release branch

go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

This reverts commit 7f6f2c7.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
go1.12.13 (released 2019/10/31) fixes an issue on macOS 10.15 Catalina
where the non-notarized installer and binaries were being rejected by
Gatekeeper. Only macOS users who hit this issue need to update.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 15669a1)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Member Author

opened as draft, because the change wasn't merged yet on master

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 8, 2019

Build succeeded.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #3808 into release/1.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/1.3    #3808   +/-   ##
============================================
  Coverage        45.59%   45.59%           
============================================
  Files              116      116           
  Lines            11465    11465           
============================================
  Hits              5227     5227           
  Misses            5338     5338           
  Partials           900      900
Flag Coverage Δ
#linux 45.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aeaac0...f7e59ae. Read the comment docs.

@thaJeztah thaJeztah marked this pull request as ready for review November 8, 2019 19:49
@thaJeztah
Copy link
Member Author

master was merged; moving out of draft

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 54658b8 into containerd:release/1.3 Nov 9, 2019
@thaJeztah thaJeztah deleted the 1.3_backport_bump_golang_1.12.13 branch November 10, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants