Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss-fuzz integration is split across (at least) 3 repositories and is fragile #10362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishalRGurrala
Copy link

@vishalRGurrala vishalRGurrala commented Jun 19, 2024

#10226

Cloning instrumentation repo from script file maintained in contrib/fuzz directory instead of projects/containerd directory

@k8s-ci-robot
Copy link

Hi @vishalRGurrala. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@samuelkarp
Copy link
Member

Can you fix the commit title and PR description? "Remove git depth" is not really what this commit is about.

@vishalRGurrala vishalRGurrala changed the title Remove git depth oss-fuzz integration is split across (at least) 3 repositories and is fragile Jun 19, 2024
@vishalRGurrala
Copy link
Author

Fixed commit title and description.

@samuelkarp
Copy link
Member

It looks like the commit message is still "Remove git depth". Can you fix that to be descriptive for what the commit actually is? Our contribution guide covers expectations for commit messages.

Checkout specific version using commit hash

Signed-off-by: Vishal Reddy Gurrala <[email protected]>
@vishalRGurrala vishalRGurrala force-pushed the feature/move-instrumentation-to-containerd branch from 850494a to 8359648 Compare June 25, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants