Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable ubuntu-24 runners #10217

Merged
merged 6 commits into from
Jun 24, 2024
Merged

ci: enable ubuntu-24 runners #10217

merged 6 commits into from
Jun 24, 2024

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented May 13, 2024

  • add ubuntu-24 github action runners into the test matrix
  • all runners have been updated to ubuntu-24 except the job where release binaries are built. Its still kept at ubuntu-20 for maintaining compatibility

Notes to reviewers:

.
edk2 (2023.11-2) unstable; urgency=medium

  * ovmf: Remove dangling symlink to removed 2M image:
    - /usr/share/OVMF/OVMF_CODE.ms.fd
.

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akhilerm
Copy link
Member Author

akhilerm commented May 13, 2024

The runners are not completely deployed from github actions side, hence the jobs queue up for long time https://github.com/actions/runner-images/blob/main/README.md#available-images

UPDATE: 03 Jun 2024
The runners are now completely deployed and issue of job queuing up is resolved.

@akhilerm akhilerm closed this May 13, 2024
@akhilerm akhilerm reopened this May 27, 2024
@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 7bd4d33 to 8584f8c Compare June 3, 2024 15:06
@akhilerm akhilerm marked this pull request as ready for review June 3, 2024 15:42
@samuelkarp samuelkarp enabled auto-merge June 3, 2024 21:27
@akhilerm
Copy link
Member Author

akhilerm commented Jun 4, 2024

The vagrant box links for downloading rockylinux/8@v9 given by the vagrantcloud API are returning 404. https://vagrantcloud.com/api/v2/vagrant/rockylinux/8, hence the failure in vagrant test

@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 7338f55 to 3eb67a9 Compare June 5, 2024 01:50
auto-merge was automatically disabled June 18, 2024 20:24

Pull request was converted to draft

@akhilerm
Copy link
Member Author

converting to draft as we are still hitting issues with running vagrant on ubuntu-24.

Currently for testing, switched to vagrant for ubuntu22.04 and using it in ubuntu 24.04

@akhilerm
Copy link
Member Author

UPDATE: There was a change in ovmf package that removed a symlink, Ref: changelog which may be causing issue with boot up.

edk2 (2023.11-2) unstable; urgency=medium

  * ovmf: Remove dangling symlink to removed 2M image:
    - /usr/share/OVMF/OVMF_CODE.ms.fd

@akhilerm akhilerm force-pushed the ubuntu-24 branch 2 times, most recently from 24bffa7 to 5ca400f Compare June 18, 2024 21:07
use ovmf 2022.02-3ubuntu0.22.04.2 so that the OVMF_CODE.fd which vagrant
looks for is still available

Signed-off-by: Akhil Mohan <[email protected]>
update all runners except the binary building job to ubuntu-24.04

Signed-off-by: Akhil Mohan <[email protected]>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan added this pull request to the merge queue Jun 24, 2024
Merged via the queue into containerd:main with commit 7310674 Jun 24, 2024
46 checks passed
@akhilerm akhilerm deleted the ubuntu-24 branch June 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants