Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tenant's storage folder when modifying the schema #5348

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Senen
Copy link
Member

@Senen Senen commented Dec 12, 2023

References

This PR solves:

Objectives

Rename the folder where tenants' file uploads live when an administrator modifies the tenant schema.

We had to do this manually until now!

@javierm javierm added this to Doing in Consul Democracy Dec 12, 2023
@Senen Senen linked an issue Dec 12, 2023 that may be closed by this pull request
@javierm javierm added the 2.1 label Dec 13, 2023
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🎉 I've left a couple of comments; let me know what you think!

app/models/tenant.rb Show resolved Hide resolved
app/models/tenant.rb Outdated Show resolved Hide resolved
spec/models/tenant_spec.rb Outdated Show resolved Hide resolved
@javierm javierm added the Bug label Dec 14, 2023
@Senen Senen marked this pull request as ready for review January 19, 2024 12:40
@Senen Senen moved this from Doing to Reviewing in Consul Democracy Jan 19, 2024
Consul Democracy automation moved this from Reviewing to Testing Jan 19, 2024
@Senen Senen merged commit fe6ae18 into master Jan 19, 2024
13 checks passed
Consul Democracy automation moved this from Testing to Release 2.1.0 Jan 19, 2024
@Senen Senen deleted the rename_storage_folder branch January 19, 2024 16:16
@javierm javierm removed the 2.1 label Jan 19, 2024
@javierm javierm self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing a tenant doesn't rename the attachment folders
2 participants