Move customizations to more intuitive admin menu section #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
approved these changes
Sep 18, 2023
javierm
force-pushed
the
intuitive-admin-menu-sections
branch
from
75320f4
to
d4f125a
Compare
taitus
reviewed
Sep 25, 2023
javierm
force-pushed
the
intuitive-admin-menu-sections
branch
from
d4f125a
to
75320f4
Compare
|
@dnsos Sorry for intruding! 🙏 I updated the branch so the tests would run (didn't run last time for some reason). I've just undone my changes. |
There were already some menu items to customization pages under the "Site content" menu. It therefore makes sense to move "Custom images" and "Custom content blocks" (which were previously located under "Settings") to "Site content" as well.
dnsos
force-pushed
the
intuitive-admin-menu-sections
branch
from
809875e
to
ae8b160
Compare
Previously the condition was needed because _without it_ the Admin::Poll::Questions::Answers::ImagesController would have resulted in settings? evaluating to true. This was undesired because that controller was scoped under Polls, so only polls? should have evaluated to true. Now that we have moved the images link to the customization menu, this check is not necessary anymore.
javierm
force-pushed
the
intuitive-admin-menu-sections
branch
from
ae8b160
to
b1bc068
Compare
|
@dnsos Thank you very much! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#4995 (no complete resolution of this issue, but an improvement discussed in it)
Objectives
There were already some menu items to customization pages under the "Site content" admin menu ("Custom pages", "Custom information texts", "Custom documents"). It therefore makes sense to move "Custom images" and "Custom content blocks" (which were previously located under "Settings") to "Site content" as well.
Visual Changes
Notes
It's possible that some admins may have memorized "Custom images" and "Custom content blocks" to be located under "Settings". However, it is more intuitive to have them under "Site content", so the possible confusion at first will probably pay off in the long-term, when all admins have more intuitive access to them.