Bump rubocop-rails from 2.15.2 to 2.20.2 #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-rails-2.20.2
branch
from
e6237f8
to
c9a4e06
Compare
javierm
force-pushed
the
dependabot/bundler/rubocop-rails-2.20.2
branch
from
5117b9a
to
34f6cf4
Compare
We should have applied this change in commit a78a8d5, since it was added in rubocop-performance 1.18.0, but forgot to do so.
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.15.2 to 2.20.2. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.15.2...v2.20.2) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
javierm
force-pushed
the
dependabot/bundler/rubocop-rails-2.20.2
branch
from
34f6cf4
to
2ccda30
Compare
This rule was added in rubocop-rails 2.16.0. Even if we always follow it, sometimes developers don't realize about this mistake immediately, so it's good to have a rule to guarantee it won't happen.
This rule was introduced in rubocop-rails 2.17.0. We don't use `where.not` with multiple conditions anywhere, but if we did, it would indeed be very confusing, so we're adding a rule to avoid that scenario.
This rule was introduced in rubocop-rails 2.18.0. Since using `response.parsed_body` is shorter than using `JSON.parse(response.body)`, this also means we can group some lines in one.
javierm
force-pushed
the
dependabot/bundler/rubocop-rails-2.20.2
branch
from
2ccda30
to
2951d0f
Compare
taitus
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rails from 2.15.2 to 2.20.2.
Release notes
Sourced from rubocop-rails's releases.
... (truncated)
Changelog
Sourced from rubocop-rails's changelog.
... (truncated)
Commits
1e29b29Cut 2.20.23cb9749Update Changelog5167b41Merge pull request #1028 from koic/fix_an_error_for_rails_unique_validation_w...cf8f9bfSuppress a newLint/MixedCaseRangeoffense26dce91Fix an error forRails/UniqueValidationWithoutIndex169427dSwitch back docs version to master95a95c9Cut 2.20.13291d77Update Changelog05ad15bMerge pull request #1021 from ydah/fix_an_error_for_rails_unique_validation_w...cdaef41Fix an error forRails/UniqueValidationWithoutIndexDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)