Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ruby to version 3.1.4 #5157

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Upgrade Ruby to version 3.1.4 #5157

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e74eff2
Upgrade Ruby to version 3.1.4
javierm Jul 20, 2023
fd9169e
Update Style/HashSyntax Rubocop rule
javierm Jul 20, 2023
f87d4b5
Add and apply Naming/BlockForwarding rubocop rule
javierm Jul 20, 2023
584176a
Add and apply Style/ArrayIntersect rubocop rule
javierm Sep 6, 2023
dcb6450
Remove no longer needed --keep-file-descriptors option
javierm Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Style/HashSyntax Rubocop rule 
Ruby 3.1 adds the option for hash shortcuts, so it's possible to write
`{ user: , poll: }` instead of `{ user: user, poll: poll }`.

By default, Rubocop expects the new syntax in Ruby 3.1. While right now
I absolutely hate this new syntax, we're allowing both the old and the
new styles because we might start adopting it once we get used to it.
  • Loading branch information
@javierm
javierm committed Sep 12, 2023
commit fd9169e0d6febd7695154a2316cd3f2e54e500d9
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,7 @@ Style/HashExcept:

Style/HashSyntax:
Enabled: true
EnforcedShorthandSyntax: either

Style/HashTransformKeys:
Enabled: true
Expand Down