Restart DelayedJob workers after they crash #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelayedJob offers the `--monitor` (aliased as `-m`) option to create a process that monitors the workers and restarts them when they crash. This change implies that, in order to stop the delayed job workers, we now need to pass the `-n` option when running `bin/delayed_job stop`: `RAILS_ENV=production bin/delayed_job -n 2 stop`.
Senen
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
I tested it in the staging server by killing the delayed_job processes by hand, and the processes were restarted automatically.
Also tested a server reboot and the Capistrano delayed_job tasks (delayed_job:start delayed_job:stop delayed_job:restart).
Also, checked how a deployment will create monitoring processes for existing installations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We're receiving reports from Consul installations saying that, once in a while, DelayedJob processes stop.
In some cases we've solved this issue by monitoring these processes with Systemd or Monit, but implementing support for these tools in a way that works on existing installations is difficult.
On the other hand, DelayedJob provides a simple way to monitor its processes that might not be as powerful as systemd but it's much better than doing nothing and it's easy to make it work on existing installations
Objectives
Notes
We might switch to systemd in the future, particularly if we upgrade Puma (see pull request #4922).
Release Notes
-noption:RAILS_ENV=production bin/delayed_job -n 2 stop.