Disable the create booths button when the polls function is disabled

[markusgeert]

References

Fixes:

• Avoid 403 error when creating booths for budgets  #4813

Objectives

What are the objectives of these changes?

Prevent the admin from trying to create booths when this is not possible, by disabling the button when the polls feature is disabled.

Visual Changes

Any visual changes? please attach screenshots (or gifs) showing them.

Down at the /admin/budgets/{budget-id} page, the 'Create booths' button looks at follows when the polls feature is disabled:

[javierm]

@markusgeert Thank you for your pull request! And apologies in advance because there are a few pending pull requests in our queue so getting to this one will take some time 🙏.

[taitus]

Hi @markusgeert,

Thank you very much for the PR 👏

Here are two small suggestions about the code, what do you think?

On the other hand, Would it be possible to add some tests to validate that everything is working correctly? 🙏

Greetings.

[taitus]

Hi @markusgeert

Thanks for apply the review 👏

I have just added the Spanish translations and add this change I got confused when I suggested the change to use the feature? method 🙏

If you feel up to it, the only thing missing would be to add a test and we could merge the PR 🥳

Greetings!

[markusgeert]

I added the Dutch translation and two tests that validate the enabled/disabled behavior. Let me know if there's anything else that should be added or changed.

[javierm]

Hi, @markusgeert 😄.

Regarding the Dutch translation you just mentioned, would it be possible to add it through our Crowdin project instead, once this pull request is merged?

The reason I'm asking is as follows: for languages other than English and Spanish, our Crowdin bot takes whatever is in Crowdin and uses it to replace what's in this repository, meaning that, if we include Dutch translations in this pull request, they will be deleted by Crowdin.

Thanks!

[markusgeert]

Hi @javierm,

I'll add it to Crowdin, no problem 🙂 . On a different note, I saw on Crowdin that a lot of the dutch translations have an English translation as the accepted answer, even though there's a dutch translation available. Should I open a new issue about this?

Regarding this PR, I think it is ready to merge now 👌.

[taitus]

Hi @markusgeert ,

I did a hard reset of your branch to master, and then included your commits. But when I did the first upload, the PR was closed because it didn't detect changes with master

Now when I try to add your commits to your branch I can't because I don't have permissions "permission denied".

I find it strange as I added changes to your commits the other day without any problems.

I'll see if I can fix it.

Sorry for the inconvenience 🙏

[markusgeert]

Alright, no worries. I can also give you commit rights to my fork if that helps?

[taitus]

@markusgeert

Alright, no worries. I can also give you commit rights to my fork if that helps?

If it's not too much trouble for you, we can try this way and see if I can upload your changes again 🙏

[taitus]

@markusgeert Thanks! And sorry for the inconvenience.

[javierm]

I've updated the changes to the latest master branch and fixed a typo in the Spanish translation.

@markusgeert Thanks a lot! 🎉