Use only one server when deploying to preproduction #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense that by default we use one server on production on two servers on preproduction. Note we're keeping `server1` instead of using just `server` in order to keep compatibility with existing installation.
We were using `server` on staging but `server1` and `server2` on preproduction and production. The reason behind it is we've always used one server on staging but sometimes we've used several servers on preproduction and production. However, this is a bit of a mess on installations which have only one server on preproduction or production and need to use the `server` key for the staging environments but `server1` for other environments. So, in order to keep compatibility with existing Consul installations, we're now allowing either `server` or `server1` on any environment.
So now it's similar to our database example file.
taitus
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
serverorserver1as deploy secrets on all environments