Show link to evaluate investments with valuation finished #5078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
link_to_evaluate
branch
from
5b37d9a
to
5113b25
Compare
javierm
force-pushed
the
link_to_evaluate
branch
from
5113b25
to
2e54904
Compare
We're going to add more cases and the test for the link to the evaluate would become too big, so we're splitting it.
This way it's still possible to access the "evaluation finished" filter in the valuation investments index.
Using this method makes it more obvious that we're loading the same investments in the budgets index as in the investments index.
We weren't allowing the `budget_id` parameter and then we were adding it manually. We were also allowing other parameters that aren't used in the valuation section. So we're allowing budget and heading, which are the only parameter we're offering filters for in the user interface. Note the `budget_id` parameter doesn't seem to make sense because we're already inside a `@budget.investments` statement, but the `budget_id` parameter is required by the `scoped_filter` method.
The budget is loaded using a method which raises an exception if it isn't found, so `@budget.present?` will always return true.
javierm
force-pushed
the
link_to_evaluate
branch
from
2e54904
to
54fbdf4
Compare
|
@Senen Cool! I've reorganized the pull request and rebased it against the latest master. |
Senen
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives