Create an administrator in new tenants #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
tenant_administrator
branch
from
0f70971
to
7c1792a
Compare
javierm
reviewed
Dec 19, 2022
Senen
force-pushed
the
tenant_administrator
branch
from
7c1792a
to
4c0ba4c
Compare
javierm
reviewed
Dec 22, 2022
Senen
force-pushed
the
tenant_administrator
branch
2 times, most recently
from
9fcd0c6
to
4e1bcf0
Compare
|
Looks like we've got a couple of flaky tests, including the one we've added in this pull request 😌. Just a theory: maybe the second one failed because the first one failed and some data leaked between tests 🤔. No idea why the first one (which is the one we've added) failed, though. The screenshot seems to show that clicking the "sign in" link resulted in a request that took too long, but I don't see a reason why that would happen. |
Senen
force-pushed
the
tenant_administrator
branch
from
4e1bcf0
to
a689638
Compare
javierm
reviewed
Dec 23, 2022
Senen
force-pushed
the
tenant_administrator
branch
from
a689638
to
cba0f13
Compare
javierm
reviewed
Dec 28, 2022
Senen
force-pushed
the
tenant_administrator
branch
from
cba0f13
to
9dfae2d
Compare
Co-Authored-By: Senén Rodero <[email protected]>
Senen
force-pushed
the
tenant_administrator
branch
from
9dfae2d
to
951eec7
Compare
javierm
approved these changes
Dec 29, 2022
javierm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: #4030
Objectives
When an admin creates a new tenant, we automatically add him as admin of the newly created tenant. The admin that is created is already automatically confirmed as it is a copy of an existing user with the same password.
Visual Changes
Notes
Add this behaviour to the multitenancy documentation.