Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations from Crowdin #5040

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Update translations from Crowdin #5040

merged 1 commit into from
Dec 13, 2022

Conversation

Senen
Copy link
Member

@Senen Senen commented Dec 1, 2022

References

This is the replacement for:

Objectives

Add the latest translations from Crowdin CONSUL project.

This PR re-introduces some inconsistent interpolations warnings we solved in the previous version in Norwegian and Arabic languages for the zero plural form of some keys. We decided to re-introduce those "inconsitencies" and ignore them in the future to make it easier updating application translations in the future.

Notes

i18n-tasks inconsistent interpolation warnings

In a previous PR we tried to solve all inconsistent interpolation warnings by updating the problematic translations from the Crowdin side. Althought we cannot solve some of them because of the Crowdin's ICU validator which validates translations before saving them, and does not allow saving translations not including the same interpolation variables than the source language. We have been talking with the Crowdin support team about this topic and there is nothing they can do from their side.

The best option is to re-introduce the Crowdin translations causing the warnings and ignore them when checking the interpolation consistency with the i18n-tasks gem in the future.

It'd be nice if there was a ignore list for the check-consistent-interpolations task, but there is no such list.

None of the re-introduced translations with inconsistencies throw an error, just a warning when running the check-consistent-interpolations task from the i18n-tasks gem.

@javierm javierm added this to Doing in Consul Democracy Dec 1, 2022
@javierm javierm added the 2.0 label Dec 3, 2022
@Senen Senen marked this pull request as ready for review December 5, 2022 10:15
@Senen Senen moved this from Doing to Reviewing in Consul Democracy Dec 5, 2022
@taitus taitus self-assigned this Dec 7, 2022
@Senen Senen moved this from Reviewing to Doing in Consul Democracy Dec 7, 2022
@Senen Senen moved this from Doing to Reviewing in Consul Democracy Dec 9, 2022
Consul Democracy automation moved this from Reviewing to Testing Dec 9, 2022
@Senen Senen merged commit b5f1b64 into master Dec 13, 2022
Consul Democracy automation moved this from Testing to Release 2.0.0 Dec 13, 2022
@Senen Senen deleted the i18n_crowdin branch December 13, 2022 16:08
@Senen Senen mentioned this pull request Dec 13, 2022
@javierm javierm added Translations and removed 2.0 labels Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants