Commits on Nov 29, 2022

1. Simplify locking current user when voting …

   Back in commit 36e4524, we wrote:
   
   > The `reload` method added to max_votes validation is needed because
   > the author gets here with some changes because of the around_action
   > `switch_locale`, which adds some changes to the current user record
   > and therefore, the lock method raises an exception when trying to lock
   > it requiring us to save or discard those record changes.
   
   This happened when `current_user` didn't have a locale stored in the
   database and the `current_locale` method returned the default locale.
   And the test "Poll Votation Type Multiple answers" would indeed fail if
   we removed the `reload` method. However, we can remove the need to
   reload the record by avoiding the mentioned changes on the current user
   record.
   
   So we're changing the `User#locale` method so it doesn't modify the user
   record.

   

   javierm committed Nov 29, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 4355138
   • Browse repository at this point

   Copy the full SHA

   4355138 View commit details

   Browse the repository at this point in the history