Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash running machine learning with no data dir #5014

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Fix crash running machine learning with no data dir #5014

merged 2 commits into from
Oct 19, 2022

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 19, 2022

References

Objectives

  • Fix a crash running machine learning scripts on a machine which doesn't have the public/machine_learning/data folder

@javierm
Fix crash running machine learning with no data dir
33f7a05 
The scripts crashed when the `data` folder wasn't present, which is the
common situation in development environments or production environments
not using Capistrano, since this folder isn't under version control.
@javierm javierm added the Bug label Oct 19, 2022
@javierm javierm self-assigned this Oct 19, 2022
@javierm javierm added this to Reviewing in Consul Democracy Oct 19, 2022
@taitus taitus self-assigned this Oct 19, 2022
Consul Democracy automation moved this from Reviewing to Testing Oct 19, 2022
@javierm javierm merged commit 0b3bccc into master Oct 19, 2022
Consul Democracy automation moved this from Testing to Release 1.6.0 Oct 19, 2022
@javierm javierm deleted the machine_learning_crash branch October 19, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @taitus