Remove some obsolete CSS code #5013

javierm · 2022-10-13T14:24:14Z

References

Removing this code will make it easier to use different colors for different tenants after implementing multitenancy Add support for multitenancy #4030
The geozone selector in poll questions isn't used since commit ab63c18 from pull request Polls Geozones #1366
The help selector isn't used since commit d679c1e from pull request Fixes social share buttons #2525
The annotator editor isn't used since commits 54e59a8 and bf20c93 from pull request LegacyLegislation migration cleanup #3275
The send-letter selector has never been used; it was introduced in commit da86c5d from pull request Verification #329, maybe by accident
The copy link feature was removed from the dashboard in commit 5bbf325 from pull request Add proposal's dashboard #3412
The select-geozone selector isn't used since commit 24dde9c from pull request Delete spending proposals #3569

Objectives

Make it easier to make changes related to colors
Remove useless code

This code isn't used since commit ab63c18.

This code isn't used since commit d679c1e.

We don't use this editor but our own custom editor, meaning this code isn't used since commits 54e59a8 and bf20c93.

This code has never been used; it was introduced in commit da86c5d, maybe by accident.

This code isn't used since we removed the copy link feature in commit 5bbf325.

This selector isn't used since commit 24dde9c.

Thi line `.budget-investment-show,` was included twice, probably due to issues while solving conflicts in git.

This mixin was being called twice for the `.budget-investment-show` selector; once in the CSS including this code for all the "Show participation" pages, and once in the CSS for budget investments.

Senen

Nice clean up! 🧹

javierm added 8 commits October 13, 2022 16:00

Remove obsolete CSS for questions geozones

ae21809

This code isn't used since commit ab63c18.

Remove obsolete CSS for the help page

e66aab7

This code isn't used since commit d679c1e.

Remove obsolete CSS for the annotator editor

9b642a0

We don't use this editor but our own custom editor, meaning this code isn't used since commits 54e59a8 and bf20c93.

Remove obsolete CSS for the verification letter

72f9aeb

This code has never been used; it was introduced in commit da86c5d, maybe by accident.

Remove obsolete CSS for the dashboard clipboard

5a654d2

This code isn't used since we removed the copy link feature in commit 5bbf325.

Remove obsolete spending proposals CSS selector

c30b528

This selector isn't used since commit 24dde9c.

Remove duplicate selector in partipation CSS

ef87abd

Thi line `.budget-investment-show,` was included twice, probably due to issues while solving conflicts in git.

Remove duplicate mixin in budget-investment-show

05cb72a

This mixin was being called twice for the `.budget-investment-show` selector; once in the CSS including this code for all the "Show participation" pages, and once in the CSS for budget investments.

javierm added the Maintenance label Oct 13, 2022

javierm self-assigned this Oct 13, 2022

javierm added this to Reviewing in Consul Democracy Oct 13, 2022

Senen approved these changes Oct 17, 2022

View reviewed changes

Consul Democracy automation moved this from Reviewing to Testing Oct 17, 2022

javierm merged commit 241ca2e into master Oct 17, 2022

Consul Democracy automation moved this from Testing to Release 1.6.0 Oct 17, 2022

javierm deleted the more_unused_css branch October 17, 2022 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove some obsolete CSS code #5013

Remove some obsolete CSS code #5013

javierm commented Oct 13, 2022 •

edited

Loading

Senen left a comment

Remove some obsolete CSS code #5013

Remove some obsolete CSS code #5013

Conversation

javierm commented Oct 13, 2022 • edited Loading

References

Objectives

Senen left a comment

Choose a reason for hiding this comment

javierm commented Oct 13, 2022 •

edited

Loading