Use Rails 6.0 methods to simplify code #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .map { |date| I18n.l(date, format: :long) } | ||
| recount_scrutiny_dates = (poll.ends_at.to_date..poll.ends_at.to_date + 1.week).to_a | ||
| .reject { |date| date == Time.zone.tomorrow } | ||
| recount_scrutiny_dates = (poll.ends_at.to_date..poll.ends_at.to_date + 1.week).excluding(Time.zone.tomorrow) |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [112/110] (https://rubystyle.guide#max-line-length)
There was a problem hiding this comment.
It's shorter than it was 😉.
javierm
force-pushed
the
rails_6.0
branch
2 times, most recently
from
3bfe01c
to
d37289b
Compare
javierm
force-pushed
the
rails_6.0_methods
branch
from
e9014b4
to
79c2fc9
Compare
javierm
force-pushed
the
rails_6.0_methods
branch
from
79c2fc9
to
812c0ca
Compare
javierm
force-pushed
the
rails_6.0
branch
3 times, most recently
from
0fdfe02
to
f7387b0
Compare
javierm
force-pushed
the
rails_6.0_methods
branch
from
812c0ca
to
65d7804
Compare
taitus
approved these changes
Aug 24, 2022
Performance tests show both methods of truncating the database take about the same time, so we can remove one dependency and we don't lose anything in the process.
The `pick` method was added in Rails 6.0.
This is consistent with `with_frozen_time`.
This method was already available as #without, but we didn't know about it.
They were introduced in Rails 6.0.
javierm
force-pushed
the
rails_6.0_methods
branch
from
65d7804
to
694100a
Compare
This method was introduced in Rails 6.0. It can be used to take an array and create a hash where the elements of the array are the indexes of the hash.
javierm
force-pushed
the
rails_6.0_methods
branch
from
694100a
to
5b844bf
Compare
taitus
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives