Close comments when the allegations phase is closed #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
hide_comments
branch
2 times, most recently
from
367aeeb
to
a1e2b65
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
force-pushed
the
hide_comments
branch
2 times, most recently
from
0d3cabc
to
24f01e7
Compare
javierm
approved these changes
Aug 5, 2022
javierm
changed the title
We were ignoring the draft version param when loading an annotation, which could result in a strange situation where we load an annotation and a draft version different than the one it belongs to. Thanks to this change, we can simplify the code a little bit. IMHO the `comments` and `new_comment` routes should have been added on member instead of on collection, which would further simplify the code. I'm leaving the routes untouched just in case changing the URL has side effects on existing installations.
javierm
force-pushed
the
hide_comments
branch
2 times, most recently
from
1e4a18b
to
cc7d4df
Compare
Co-Authored-By: Julian Nicolas Herrero <[email protected]> Co-Authored-By: Javi Martín <[email protected]>
taitus
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
If a user comments a text of collaborative legislation during the allegations phase, and further comments are added to the text once the phase is over, these are added to the text.
It should not be possible to add more comments to the text after the allegations phase is finished, so this PR hides comment form on annotations when allegations phase is closed on legislation processes.