Simplify staging/preproduction environment files #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already doing so by duplicating the code; now we're doing it
explicitly.
This is going to help because we're going to do a few changes in the
environment files, and this way we don't have to do everything twice.
Note that, after we're finished with these changes, the staging and
production environments will be mostly identical and we could simply
require the production environment configuration in the `staging.rb`
file. We aren't doing so because some Consul installations might have
customized these files and it'd be hard for them to deal with all these
changes at once. So, for now, they'll only have to deal with the
possible differences between their staging and preproduction
environments.
Changes to the preproduction environment that won't be applied to the
staging environment can be added like this:
require Rails.root.join("config", "environments", "staging")
Rails.application.configure do
config.log_level = :warn
end
We removed the assets initializer in commit 91cd1ce.
We changed the structure of the production environment file in commit eb36b7e, but forgot to do so for staging and preproduction. We're also changing the comments in the production environment file so they use double quotes, like we do everywhere else. After these changes, the staging and production environments are mostly identical, and we could simply require the production environment configuration in the `staging.rb` file. We aren't doing so because we've just done changes affecting the preproduction environment and, since Consul installations might have customized these files, it might be hard for them to deal with all these changes at once.
Merged
taitus
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
After these changes, the staging and production environments are mostly identical, and we could simply require the production environment configuration in the
staging.rbfile. We aren't doing so because we're doing changes affecting the preproduction environment and, since Consul installations might have customized these files, it would be hard for them to deal with all those changes at once.Release notes
config/environments/preproduction.rbis not identical to yourconfig/environments/staging.rb, you'll have to change the former in order to include the differences (or you can also choose to base it on your production environment instead). If you're using the staging environment but not the preproduction one (or you aren't using either of them), ignore this warning.