Reduce conflicting queries/requests in system tests #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were cases where we clicked the button to submit the form and immediately we visited a different page. In the past, we've had similar code produce PG::ProtocolViolation errors in similar situations. Since we've had these errors a few times in the nested imageable specs, there's a chance they're related to the absence of the expectation. Although I'm not even remotely sure this will fix these issues, at least we now follow the convention of making expectations after every request. Note we're changing both the nested imageable and nested documentable specs. Only the nested imageable would need to be changed because it's the one where there's a `visit` inside the `imageable_redirected_to_resource_show_or_navigate_to` method. I'm changing both for consistency.
We were doing a `mappable.map_location` call in an `expect` which might result in a database queries. Doing database queries in a test after the process running the browser has started might result in exceptions while running our test suite.
We were clicking on the "Sign in" link right after clicking on the "Sign out" link, which might result in simultaneous requests and exceptions when running our test suite. So we're adding an expectation to make sure the first request has finished before starting the following one.
Furthermore, using `Poll.all` results in a database query, and doing so after the process running the browser has started might result in failures when running our test suite.
When we perform database queries in tests after the process running the browser has started, we sometimes get failures in our test suite due to both the tests and the browser accessing the database at the same time.
javierm
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| do_login_for mappable.author, management: management | ||
|
|
||
| visit send(mappable_edit_path, id: mappable.id) | ||
|
|
||
| expect(page).to have_content "Navigate the map to the location and place the marker." | ||
| validate_latitude_longitude(mappable, mappable_factory_name) | ||
| expect(page).to have_field "#{mappable_factory_name}_map_location_attributes_latitude", type: :hidden, with: "51.48" |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [122/110] (https://rubystyle.guide#max-line-length)
| do_login_for mappable.author, management: management | ||
|
|
||
| visit send(mappable_edit_path, id: mappable.id) | ||
|
|
||
| expect(page).to have_content "Navigate the map to the location and place the marker." | ||
| validate_latitude_longitude(mappable, mappable_factory_name) | ||
| expect(page).to have_field "#{mappable_factory_name}_map_location_attributes_latitude", type: :hidden, with: "51.48" | ||
| expect(page).to have_field "#{mappable_factory_name}_map_location_attributes_longitude", type: :hidden, with: "0.0" |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [121/110] (https://rubystyle.guide#max-line-length)
taitus
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
PG::ProtocolViolationexceptions when running our test suite