Describe enabled processes in the consul.json URL #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea to show the status of the existing features was done in commit 7339a98. Back then, we didn't have the separate `process.` prefix, and so processes were enabled/disabled using settings like `feature.debates` instead of `process.debates`. IMHO making the information about the enabled features public could potentially be a bit risky since it gives too much information about the current status of the application. Showing which processes are enabled, on the other hand, is pretty harmless, and it's the reason why this feature was added in the first place.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -14,6 +14,6 @@ def consul_installation_details | |||
| end | |||
|
|
|||
| def settings_feature_flags | |||
| Setting.where("key LIKE 'feature.%'").each_with_object({}) { |x, n| n[x.key.remove("feature.")] = x.value } | |||
| Setting.where("key LIKE 'process.%'").each_with_object({}) { |x, n| n[x.key.remove("process.")] = x.value } | |||
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [113/110] (https://rubystyle.guide#max-line-length)
taitus
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives