Add more images to admin site customization #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
admin_images
branch
5 times, most recently
from
55694f4
to
707b9ab
Compare
Apparently the dashboard branch wasn't updated after we extracted a common head for all layouts in commit 6e4f697, so when said branch was merged we reintroduced the duplication. Furthermore, we forgot to add to the dashboard layout the changes we were applying to the common head partial.
This way it'll be easier to write tests for it. We also get rid of another helper file :).
javierm
approved these changes
Aug 3, 2022
We forgot to change the line rendering the image in commits 3574bf8 and 810bdae, and so the custom image was being ignored. Note that, in the test, we're stubbing a constant instead of adding a new image. The main reason is that, if we add a new image, forks would have to change the image when they change the `VALID_IMAGES` constant; otherwise the tests would fail.
This way it'll be possible to overwrite the valid mime types in a custom model.
taitus
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
To make CONSUL customization easier this PR adds more images to the site customization
/admin/site_customization/images.The images have been added:
budget_investment_no_imagewelcome_processauth_bgfaviconThese images already exist in the repository but it will now be possible to modify them from the administration panel. 👩🏻🎨