Include machine learning settings type #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like these lines were added on a branch which didn't include commit 3da4ee0 but were merged after that commit was merged. In any case, since we're already using the `:admin` tag in the whole file, these lines aren't necessary.
javierm
force-pushed
the
machine_learning_settings
branch
2 times, most recently
from
3b09793
to
a89e15b
Compare
On the Configuration settings page three settings appeared without description: * Comments Summary: No description. * Related Content: No description. * Tags: No description. These settings are related with the AI / Machine learning feature. They only should appear on AI / Machine learning setting page when the feature is enabled.
javierm
force-pushed
the
machine_learning_settings
branch
from
a89e15b
to
682781c
Compare
javierm
approved these changes
May 5, 2022
|
It works fine in the testing server and the spec that fails is not related to PR and looks like a flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the Configuration settings page three settings appear without description:
These settings are related with the AI / Machine learning feature. They only should appear on AI / Machine learning setting page when the feature is enabled. 馃
This PR include machine learning settings type.
Notes
Actually adding the
machine_learningtype prevents them from being added to theconfigurationlist in models/setting.rb, but as that type is not being used, maybe there is another way to exclude them. 馃Visual changes
Settings removed from Configuration settings list