Fix Registration Without E-Mail

[iraline]

References

Related to the issue #4779

Objectives

Do not allow the form to be sent if the email is not filled in

Visual Changes

When the user tries to submit the form without filling the email, it shows a message.

Notes

Some messages about deprecations:

!global assignments won't be able to declare new variables in future versions.
Consider adding `$alert-color: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$primary-color: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$secondary-color: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$success-color: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$warning-color: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-size: null` at the top level.

!global assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-bp-value: null` at the top level.

[taitus]

Hi, @iraline

Thanks for creating the PR to keep reducing the issues 🙏

As for the code, using required: true doesn’t seem very consistent with other required fields and the rest of the forms in the application.

What do you think if we apply this patch?
patch.txt

Do you feel like applying the patch and writing a test to validate it?

Regards and thanks a lot!

[iraline]

Hi @taitus! Sure, I can do this. 😊

[taitus]

Hi @iraline,

Thank you for adding the changes!

A couple of details before we merge the PR into master:

• Would it be too much trouble to group the 3 commits into one?
  The change that is added in the first commit Add require in email is removed in the second commit.
  And the third commit pronto run could already be included in the second commit adding limitation to not save blank email in model

• Finally, the line: validates :email, presence: true, if: :email_required?
  I think by using the devise gem, it already takes care of the email_required? call. The validatable module seems to make this call.

If you agree to apply the changes, great. If not, don't worry, before closing the new release 1.5 we will check the status of the PR and if it hasn't changed we will apply them.

Best regards and thank you very much for your contributions.

[taitus]

Hi @iraline,

Thank you for the changes.

The PR is almost ready to merge. Just one more suggestion:

• The spec that has been added doesn't fail if we remove the changes from this PR. To make it fail without the changes and pass with the changes you would need to add the following line at the beginning of the spec:
  Setting["feature.user.skip_verification"] = true

For our part, once this change is added, we will proceed to merge in master. If you could apply this change it would be great.

Best regards and thank you very much for your contributions.