Show budgets map only if feature is enabled #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
budgets_map
branch
3 times, most recently
from
2f49cfc
to
68845f7
Compare
We're going to make a change, and it's easier if we've already got a component with tests so we don't have to write system tests to check whether the map is rendered.
These helpers aren't used here since commit 090f1bc.
We forgot to do so in commit 04605d5. Before that commit, we were testing the links weren't displayed in the "informing" phase as opposed to the "finished" phase. After that commit, they weren't displayed anywhere since a <select> field was shown instead. Since then, we've replaced the <select> field with the links generated by the `Budgets::Investments::FiltersComponent`. We've already got tests for these links.
javierm
force-pushed
the
budgets_map
branch
2 times, most recently
from
075c1d0
to
64efd7d
Compare
It isn't used since commit c34aa54.
taitus
approved these changes
May 3, 2022
|
@decabeza Cool, thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
The Participatory budgets page shows a map with Budget investments' proposals located geographically. 🗺️
This PR hides the map if the setting "Proposals and budget investments geolocation" (
Setting["feature.map"]) is disabled to avoid showing an empty map.