Fix typos in the English version #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
typos
branch
2 times, most recently
from
a860e7b
to
4d1b6ec
Compare
javierm
force-pushed
the
typos
branch
2 times, most recently
from
935a25e
to
ad7136f
Compare
Senen
approved these changes
Jun 1, 2022
As suggested by Pomerange; the "help about" construction indeed sounds a bit strange.
We used "retire" because we translated it literally from the Spanish verb "retirar" which can mean both "retire" and "withdraw". Note we're still using "retire" in database fields and method names; changing that might make it harder to upgrade from a previous version of CONSUL.
As suggested by Pomerange.
In English, circumstancial complements usually go after the direct complement.
As suggested by Pomerange; "proposals" sounded strange as an adjective.
As suggested by Pomerange, "credentials" also refers to academic qualifications, and so might be confusing.
We were saying that actions marked with an asterisk were only possible when users were verified. However, there were no actions marked with an asterisk; instead, we didn't show these actions to non-verified users. Besides, the concept of Census doesn't exist in many CONSUL installations, where verification is done through other means, so the text saying that only users on Census could do certain things wasn't correct in these cases. Due to that, we're removing the asterisk in the Spanish version as well. We're also removing the asterisk in the default welcome pages, since we're already saying which action can't be done until the account is verified. In the case of the residence verification page, we had asterisks but we didn't explain what the asterisk stood for, so we're also removing it.
We had the same texts four times, with slight variations in the case of the management section. We're unifying them under the "verification" i18n namespace, since the texts are about actions which can be done depending on whether users are verified or not. Note the names of the i18n keys aren't very consistent, since we use "debates" in plural but "proposal" in singular. We're leaving it like this so existing translations aren't affected.
"Participate in the final voting" was a concept which was hard to understand since many people would think it was related to the voting/polls section and that somehow there was going to be a "final" poll. So we use "Vote for budget projects" instead. Thanks Pomerange for the suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives