Add Rails 6.0 compatibility #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `only:` key does not apply to model callbacks. It was added in commit 1077e25, probably by accident. Using this key raises an error in Rails 6.0.
We did a similar change in commit 47925fb, and we were getting a warning in Rails 6.0: DEPRECATION WARNING: render file: should be given the absolute path to a file Since using `render file:` would ignore views in custom folders, we're using `render template:` instead.
We were getting a warning in Rails 6: DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller.
In SQL, conditions like: ``` tag_id IN (x) AND taggable_type='Debate' OR taggable_type='Proposal' ``` Don't work as intended; we need to write: ``` tag_id IN (x) AND (taggable_type='Debate' OR taggable_type='Proposal') ``` Due to this bug, we were returning taggings for proposals without intending to do so. Since the code was very hard to read, we're also simplifying it.
We were getting a warning in Rails 6.0: DEPRECATION WARNING: Class level methods will no longer inherit scoping from `public_for_api` in Rails 6.1. To continue using the scoped relation, pass it into the block directly. To instead access the full set of models, as Rails 6.1 will, use `ActsAsTaggableOn::Tag.default_scoped`.
taitus
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
proposals#createdaction