Fix invalid HTML in application layout #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
approved these changes
Dec 30, 2021
javierm
force-pushed
the
invalid_html
branch
from
c05ce91
to
c66b822
Compare
We forgot to remove it in commit f28a5cc. The generated HTML was invalid, with the error: > Element meta is missing one or more of the following attributes: > content, property.
See foundation/foundation-sites issue 12167, which was fixed in Foundation 6.7.1. However, since Foundation 6.7 requires Node 12 and the foundation-rails gem hasn't been maintained for a year and a half, we're not updating for now.
javierm
force-pushed
the
invalid_html
branch
from
c66b822
to
791b2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
track_eventmethodObjectives