Fix comment notifications on legislation proposals #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `commentable_url` method wasn't updated when we added legislation proposals. Back when we first created this method, we couldn't pass budget investments or topics directly to `polymorphic_url` because they are nested resources. That isn't the case since commit ff93f5a, so now we can simplify this method. We're keeping the `commentable_url` method for now in order to keep compatibility with custom changes that might use it, although this method isn't consistent with the `commentable_path` method (which receives a comment, and not a commentable), and so we might have to revisit this code in the future.
taitus
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives