Change the way we handle source strings updates #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `update_without_changes`, previous translations are kept even when the source string changed utterly. Using this option caused some problems when updating source language strings, as the translators do not get any notification, and the old translation keeps approved, so translators do not have an easy way to find those strings in Crowdin. With the `update_as_unapproved` option, translators and Crowdin managers can find those translations that need to be updated by searching among not approved translations. Quoting Crowdin's docs [1]: > update_without_changes - preserve translations and validations of changed strings > update_as_unapproved - preserve translations of changed strings and remove validations of those translations if they exist [1] https://support.crowdin.com/configuration-file/#changed-strings-update
javierm
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
We changed a source string with interpolations in #4665. However, as we were using the Crowdin
update_option: update_as_unapproved, the other languages previous translations of this string kept as approved, so Crowdin managers and translations did not realize about this change.More precisely, we changed the source string from
Are you sure? This action will delete %{resource_name} '%{name}' and can't be undone.toAre you sure? This action will delete \"%{name}\" and can't be undone.which only has one interpolation argument. As other languages keep having the old translation with two interpolations arguments, the application crashed when loading the translation.This problem affects the following languages: German, Turkish, Italian, Romanian and Swedish.
Objectives
Change the way we handle source strings updates, so the other languages translations approvals are removed, and we have a way to find them.
With the
update_without_changes, previous translations are kept even when the source string changed utterly. Using this option caused some problems when updating source language strings, as the translators do not get any notification, and the old translation keeps approved, so translators do not have an easy way to find those strings in Crowdin.With the
update_as_unapprovedoption, we hope translators and Crowdin managers can find those translations that need to be updated by searching among not approved translations.Quoting Crowdin's docs [1]:
[1] https://support.crowdin.com/configuration-file/#changed-strings-update