Make dev seeds independent on available locales #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
dev_seeds_without_english
branch
from
2ff4890
to
975dde9
Compare
We're using Faker during this task, and it depends on English being available as a fallback for methods like the Lorem ipsum ones.
These locales are officially maintained by CONSUL developers, so we're using them when available. This way we'll be able to use `random_locales` in places where we're manually using English and Spanish, giving support to other locales while maintaining compatibility with the current version.
So it's easier to differentiate between them during development.
Now changing the code dealing with locales is going to be easier.
javierm
force-pushed
the
dev_seeds_without_english
branch
4 times, most recently
from
aff00c6
to
8f48d81
Compare
taitus
approved these changes
Dec 14, 2021
Some developers work on CONSUL installations where Spanish and/or
English aren't part of the available locales. In those cases, the
`dev_seed` task was crashing because we were using attributes like
`name_en` and `name_es`.
So we're using attributes for random locales instead.
We're using a proc so we don't have code like this all over the place:
random_locales.map do |locale|
I18n.with_locale(locale) do
phase.name = I18n.t("budgets.phase.#{phase.kind}")
phase.save!
end
end
This would make the code harder to read and would execute a `save!` once
per locale, which would make the task much slower.
We could also avoid the procs writing something like:
def random_locales_attributes(**attribute_names_with_values)
random_locales.each_with_object({}) do |locale, attributes|
I18n.with_locale(locale) do
attribute_names_with_values.each do |attribute_name, (i18n_key, i18n_args)|
value = I18n.t(i18n_key, (i18n_args || {}).merge(language: I18n.t("i18n.language.name")))
attributes["#{attribute_name}_#{locale.to_s.underscore}"] = value
end
end
end
end
And calling the method with with:
random_locales_attributes(name: ["seeds.budgets.name", year: Date.current.year - 1])
However, this code would also be different that what we usually do, we'd
have to apply some magic to pass the `language:` parameter, and the
strings wouldn't be recognized by i18n-tasks, so we aren't sure we're
really gaining anything.
javierm
force-pushed
the
dev_seeds_without_english
branch
from
8f48d81
to
43d90d5
Compare
We were making some typos during development in the name of the keys and tests were still passing. We're also removing some texts that were never used.
javierm
force-pushed
the
dev_seeds_without_english
branch
from
43d90d5
to
d59d9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
db:dev_seedtask on CONSUL installations using languages which don't include English and Spanish