Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix investments list images width in Chrome 93+ #4722

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Fix investments list images width in Chrome 93+ #4722

merged 1 commit into from
Oct 28, 2021

Conversation

taitus
Copy link
Member

@taitus taitus commented Oct 27, 2021 •
edited by javierm
Loading

References

Objectives

Display the images correctly in budget investments list in Chrome 93 or later.

Visual Changes

  • Before
    In budget investments list, there is blank space between the image and the border containing the image:

  • After
    In budget investments list, the image fills the full width of the border containing it:

@taitus taitus self-assigned this Oct 27, 2021
@taitus taitus added the Budgets label Oct 27, 2021
@taitus taitus added this to Reviewing in Consul Democracy via automation Oct 27, 2021
@javierm javierm changed the title Improve width image on investments list Fix investments list images width on Chrome 90+ Oct 27, 2021
javierm
javierm approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! 😄

Consul Democracy automation moved this from Reviewing to Testing Oct 27, 2021
@javierm javierm changed the title Fix investments list images width on Chrome 90+ Fix investments list images width in Chrome 90+ Oct 27, 2021
@javierm javierm changed the title Fix investments list images width in Chrome 90+ Fix investments list images width in Chrome 90+ Oct 27, 2021
@javierm javierm changed the title Fix investments list images width in Chrome 90+ Fix investments list images width in Chrome 93+ Oct 28, 2021
@taitus taitus merged commit 64c98cb into master Oct 28, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Oct 28, 2021
@taitus taitus deleted the improve-investment-list-img branch October 28, 2021 09:58
@javierm javierm self-assigned this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Budgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List of investments does not display the images correctly in Chrome
2 participants
@taitus @javierm