Include DelayedJob errors in Errbit exceptions #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
delayed_errbit
branch
from
991c8f0
to
b0a7a6d
Compare
javierm
force-pushed
the
delayed_errbit
branch
3 times, most recently
from
24170e1
to
0a61305
Compare
The integration between Airbrake/Errbit and DelayedJob wasn't working because we require our dependencies in alphabetic order, and so by the time `airbrake` was required, `delayed_job` wasn't loaded. So we're manually requiring the integration.
javierm
force-pushed
the
delayed_errbit
branch
from
0a61305
to
9f21c27
Compare
taitus
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
The integration between Airbrake/Errbit and DelayedJob wasn't working because we require our dependencies in alphabetic order, and so by the time
airbrakewas required,delayed_jobwasn't loaded.Objectives