Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Add image" button styles in budget phases #4687

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 2, 2021

References

Visual Changes

Before these changes

The button to add image to a phase fills in the whole screen width

After these changes

The button to add image to a phase fills is as wide as its text

@javierm javierm self-assigned this Sep 2, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Sep 2, 2021
@javierm javierm force-pushed the phases_image_button branch 2 times, most recently from 2ee5d69 to b8705c1 Compare September 12, 2021 11:46
It was broken since we fixed issues with other image fields in commit
394a94c, because there we added a fieldset for the image fields, and
so they inherited the styles in budget phases fields (these styles were
added before it was possible to attach an image to a phase).
@javierm javierm changed the title Fix "Add image" button stlyes in budget phases Fix "Add image" button styles in budget phases Sep 13, 2021
@taitus taitus assigned taitus and javierm and unassigned javierm Sep 14, 2021
Consul Democracy automation moved this from Reviewing to Testing Sep 14, 2021
@javierm javierm merged commit 288ae13 into master Sep 14, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Sep 14, 2021
@javierm javierm deleted the phases_image_button branch September 14, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants