Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add length validation for debate description #4674

Merged
merged 4 commits into from
Aug 28, 2021
Merged

Add length validation for debate description #4674

merged 4 commits into from
Aug 28, 2021

Conversation

efgalvao
Copy link
Contributor

References

Fixes issue #4013

Objectives

Changes the method of validating the debate description field. Now the input is sanitized of the html tags before validating.

  • With nil description:
    Screenshot from 2021-08-26 11-46-06

  • With too short description:
    Screenshot from 2021-08-26 11-46-27

  • With too long description:
    Screenshot from 2021-08-26 11-47-42

Visual Changes

  • Now the short/long length description error message is below the "can't be blank" message.
    Screenshot from 2021-08-26 11-46-06

Notes

This PR is a rebased version of #4437

@javierm javierm added this to Reviewing in Consul Democracy via automation Aug 28, 2021
@javierm javierm self-assigned this Aug 28, 2021
@javierm javierm added the UX label Aug 28, 2021
javierm
javierm approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efgalvao Thanks a lot! 🙏 We appreciate it 😄.

Consul Democracy automation moved this from Reviewing to Testing Aug 28, 2021
@javierm javierm linked an issue Aug 28, 2021 that may be closed by this pull request
Review length validations in ckeditor fields #4013
Closed
@javierm javierm merged commit 713ae54 into consuldemocracy:master Aug 28, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Aug 28, 2021
@javierm javierm changed the title Issue#4013 lenghth validations Add length validation for debate description Aug 28, 2021
@javierm javierm mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@javierm javierm

@efgalvao efgalvao

Labels
UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review length validations in ckeditor fields
2 participants
@efgalvao @javierm