Upgrade Ruby to version 2.7.4 #4662
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
changed the base branch from
master
to
dependabot/bundler/master/rubocop-rails-and-rubocop-performance-and-rubocop-rspec-and-rubocop-2.11.3
Note this version includes Bundler 2, so we can finally upgrade.
We were getting hundreds of "warning: URI.escape is obsolete" messages. So we're using `URI::DEFAULT_PARSER.escape` instead. IMHO it's OK to add this monkey-patch because we're replacing Paperclip with Active Storage, and when we finish with that we'll delete this file.
There was a problem hiding this comment.
Hi, @javierm
As ruby 2.7 already includes bundler version 2 I wonder if we may delete the line 38 from the Dockerfile. Same with /bin/setup#L17 and /bin/update#L17 🤔
The Dockerfile seems to work fine when running docker build -t consul . without the mentioned line.
|
@Senen It looks like we could have actually done so after upgrading to Ruby 2.6 🤔. But, yes, now it's a good moment 👍. I've updated the pull request changing the Dockerfile. I'm not so sure about the other two, since those are scripts automatically generated by Rails and use the time gem install bundler --conservative
=> gem install bundler --conservative 0,42s user 0,16s system 114% cpu 0,508 totalI'm usually fond of deleting code that does nothing, but since this is an external script and every time we upgrade to a new Rails version we'd have to remember to remove this line, I'd vote for leaving it like that. |
javierm
force-pushed
the
ruby2.7
branch
2 times, most recently
from
8982dc7
to
f087d6f
Compare
I think we could have already done so when upgrading Ruby to version 2.6.x (which also included the Bundler gem), but since we didn't, now that we've upgraded to Bundler 2.x it's probably a good moment.
Objectives
Notes
Ruby 2.7 introduced a separation of positional and keyword arguments, which caused warnings on almost every existing gem. This was solved by silencing those warnings in Ruby 2.7.2. However, before merging this pull request we're still going to update as many gems as possible and check the warnings in order to study how hard it will be to upgrade to Ruby 3.