Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump airbrake from 7.4.0 to 11.0.3 #4657

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2021

Bumps airbrake from 7.4.0 to 11.0.3.

Changelog

Sourced from airbrake's changelog.

[v11.0.3][v11.0.3] (May 13, 2021)

  • Fixed Sneakers integration when 3rd party code monkey-patches Sneakers::Worker#process_work (#1164)
  • Fixed ActionCable integration when 3rd party code monkey-patches ActionCable::Channel::Base#perform_action (#1165)
  • Fixed Resque integration when 3rd party code monkey-patches Resque::Job#perform (#1166)
  • Fixed Rake integration when 3rd party code monkey-patches Rake::Task#execute (#1167)

[v11.0.2][v11.0.2] (May 12, 2021)

  • Fixed HTTP::Client performance breakdown when 3rd party code monkey-patches HTTP::Client#perform (#1162)

[v11.0.1][v11.0.1] (October 20, 2020)

  • Fixed rake airbrake::deploy crashing with NoMethodError: undefined method `level' for nil:NilClass when the RAILS_LOG_TO_STDOUT environment variable is set (#1129)
  • Bumped airbrake-ruby requirement to ~> 5.1 (#1133)

[v11.0.0][v11.0.0] (August 17, 2020)

Breaking changes:

  • Dropped support for Rails v3.2 (#1118)
  • Dropped support for Ruby 2.1 (#1119)
  • Dropped support for Ruby 2.2 (#1120)

Bug fixes:

  • Rails APM: fixed double slash in front of a route name when mounting engines at / (#1111)
  • Rails: fixed broken initialization for some apps due to the load order of initializers (#1112)

Maintenance:

... (truncated)

Commits
  • 1316a43 Merge pull request #1168 from airbrake/release-11-0-3
  • d30f7a4 Release v11.0.3
  • a21fa79 Merge pull request #1167 from airbrake/rake-prepend
  • def7059 rake: monkey-patch with prepend instead of method chaining
  • b2e3976 Merge pull request #1166 from airbrake/resque-prepend
  • 3fb3fda resque: monkey-patch with prepend instead of method chaining
  • 6cf1e0c Merge pull request #1165 from airbrake/action-cable-prepend
  • 44aec62 action_cable: monkey-patch with prepend instead of method chaining
  • 6534bdc Merge pull request #1164 from airbrake/sneakers-prepend
  • c99a9f5 sneakers: monkey-patch with prepend instead of method chaining
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that updates a dependency label Aug 13, 2021
@javierm
Copy link
Member

javierm commented Aug 16, 2021

@dependabot rebase

Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of the custom information texts tests fail sometimes because the page takes too long to load. After upgrading airbrake, maybe because of the way requests are intercepted, or maybe because of the rbtree3 dependency, it looks like requests are a bit slower and so these tests fail 100% of the time.

We can't merge before solving this issue.

@dependabot dependabot bot force-pushed the dependabot/bundler/master/airbrake-11.0.3 branch from 033c47d to 03c06b1 Compare August 16, 2021 00:38
@javierm javierm marked this pull request as draft August 16, 2021 00:38
@javierm
Copy link
Member

javierm commented Sep 19, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/master/airbrake-11.0.3 branch from 03c06b1 to 995f1c0 Compare September 19, 2021 02:56
@javierm javierm force-pushed the dependabot/bundler/master/airbrake-11.0.3 branch 2 times, most recently from 6f2b3b6 to b9164be Compare October 7, 2021 02:09
@javierm javierm marked this pull request as ready for review October 7, 2021 02:10
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like disabling performance stats (as recommended by Errbit) solves the performance issues.

Note we're using `config.performance_stats = false` because enabling it
was causing a huge performance hit; pages were about 2-4 times slower
and some tests failed since requests took longer than Capybara's default
max wait time. Errbit also recommends disabling this option since
Errbit doesn't handle performance stats.

Bumps [airbrake](https://github.com/airbrake/airbrake) from 7.4.0 to 11.0.3.
- [Release notes](https://github.com/airbrake/airbrake/releases)
- [Changelog](https://github.com/airbrake/airbrake/blob/master/CHANGELOG.md)
- [Commits](airbrake/airbrake@v7.4.0...v11.0.3)

---
updated-dependencies:
- dependency-name: airbrake
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@javierm javierm force-pushed the dependabot/bundler/master/airbrake-11.0.3 branch from b9164be to 838e5a5 Compare October 7, 2021 02:13
@javierm javierm self-assigned this Oct 7, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Oct 7, 2021
@javierm javierm moved this from Reviewing to Testing in Consul Democracy Oct 7, 2021
@javierm javierm marked this pull request as draft October 7, 2021 02:21
@javierm javierm removed the post-1.4 label Oct 7, 2021
@javierm javierm marked this pull request as ready for review October 7, 2021 16:39
@javierm javierm merged commit a0c7856 into master Oct 7, 2021
Consul Democracy automation moved this from Testing to Release 1.4.0 Oct 7, 2021
@javierm javierm deleted the dependabot/bundler/master/airbrake-11.0.3 branch October 7, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant