Use telephone fields in phone number form controls #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
phone_number_field
branch
from
df3790d
to
af3ef82
Compare
javierm
force-pushed
the
phone_number_field
branch
from
af3ef82
to
7cf750d
Compare
javierm
force-pushed
the
phone_number_field
branch
2 times, most recently
from
4200dac
to
297fbac
Compare
javierm
changed the title
javierm
force-pushed
the
phone_number_field
branch
3 times, most recently
from
01bf8eb
to
74f8ca2
Compare
javierm
force-pushed
the
phone_number_field
branch
from
74f8ca2
to
2ffe7a0
Compare
javierm
force-pushed
the
phone_number_field
branch
from
2ffe7a0
to
4614867
Compare
Using a field with `type="tel"` causes most mobile phone browsers to show a numeric keyboard which makes it easy to enter phone numbers. We aren't using a number field because some browsers show "spinners" to increment/decrement numbers (which doesn't make much sense in a phone number) and because they don't allow characters like spaces. Phone numbers can have characters like spaces, dashes, parenthesis, asterisks, the plus sign, ... Since phone number formats vary depending on the region, and sometimes even within the same region several different formats can be used, for now we aren't offering any kind of format validation. We could offer a format validation that rejects just letters (although there are cases where letters are actually allowed). However, this causes issues at both the server side and the client side. We could use a client-side validation adding a `pattern` attribute to the field, but that would be something unlike anything else we use in the application, and we would need to to write some JavaScript in order to use a proper error message. On the other hand, if we add a server-side validation, we might find out existing users are invalid, and it would be impossible to update them in the many places where we update users assuming they were valid in the first place. We'd have to add a rake task to update existing user records and make sure they contain a valid phone number or create a setting so this validation only applies to new CONSUL installations. Another option would be to add a per-form validation, so the phone number is only validated in pages where it is introduced. All the mentioned scenarios offer certain complexities. So, for now, we're keeping things simple. Co-Authored-By: decabeza <[email protected]>
javierm
force-pushed
the
phone_number_field
branch
from
4614867
to
ae91361
Compare
taitus
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Make it easier for mobile phone users to enter a phone number.
Visual Changes
Before these changes
Phone browsers shows a alphanumeric keyboard:
After these changes
Phone browsers shows a numeric keyboard which makes it easy to enter phone numbers.
