Fix updating a translation to its original value #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_updating_original_translation
branch
from
5db22da
to
9db9ff8
Compare
javierm
force-pushed
the
fix_updating_original_translation
branch
from
9db9ff8
to
4831658
Compare
javierm
force-pushed
the
fix_updating_original_translation
branch
from
4831658
to
f0d0f1f
Compare
This way we can test it properly, which will be helpful when fixing bugs.
Users were unable to reset a translation to its original value after updating it because we weren't storing anything in the database in that case. I've considered deleting the existing translation when this happens. I'm not sure about which approach is the better one, so I'm using the less destructive one.
Senen
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives